manually build dev image instead of publishing it every version#4409
manually build dev image instead of publishing it every version#4409lvhan028 merged 2 commits intoInternLM:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR splits the “dev” Docker image publishing out of the main Docker publish workflow and makes it a manually-triggered workflow, reducing automatic dev image publishes on every version push/tag.
Changes:
- Add a new
docker_dev.ymlGitHub Actions workflow that publishes the dev Docker image viaworkflow_dispatch. - Remove the dev image publishing job from
docker.yml. - Update
actions/checkoutusage indocker.ymlfromv3tov4.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/docker_dev.yml | New manual workflow to build/push the dev CUDA 12.8 image. |
| .github/workflows/docker.yml | Removes dev image job; updates actions/checkout to v4 for remaining jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - name: Build and push Docker image | ||
| run: | | ||
| echo $TAG | ||
| docker build . -f docker/Dockerfile_dev -t ${TAG} | ||
| docker push $TAG |
There was a problem hiding this comment.
This workflow builds the dev image using docker/Dockerfile_dev, but the previously removed publish_dev_docker_image job built from docker/Dockerfile with --build-arg IMAGE_TYPE=dev (and implicitly different defaults like CUDA_VERSION/PYTHON_VERSION). That changes the contents/behavior of the published dev tag, not just when it’s built. If the goal is only to make the existing dev image manual, consider switching this workflow back to the same Dockerfile/build-args as before; otherwise, please update the PR title/description (and possibly the tag name) to reflect that the dev image definition has changed.
No description provided.